Skip to content

feat(compositor): [#223] output-space error budget — maxValueError в единицах результата - #281

Merged
lemone112 merged 12 commits into
mainfrom
feat/compositor-error-bound-223
Aug 18, 2026
Merged

feat(compositor): [#223] output-space error budget — maxValueError в единицах результата#281
lemone112 merged 12 commits into
mainfrom
feat/compositor-error-bound-223

Conversation

@lemone112

@lemone112 lemone112 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Что

Закрывает #223: ошибка реконструкции compositor-артефакта выражается в ЕДИНИЦАХ РЕЗУЛЬТАТА (px, unitless), а не в долях нормированного прогресса — без perceptual magic numbers.

  • Публичный контракт: maxValueError в SpringLinearOptions; эффективный tolerance выводится законом из (диапазон, бюджет ошибки).
  • Полная полоса допуска гарантирована до терминального узла артефакта (RED-тест терминальной полосы).
  • Единый горизонт артефакта в тестах; pole-space error oracle расширен.
  • Size headroom восстановлен отдельным perf-коммитом; value-budget не попадает в controller-бандлы.

История

TDD-цепочка из 12 коммитов (RED → интеграция → закон → полоса → perf), пересобрана на main после #280 (сплит валидаторов #218 уже в main — конфликтные коммиты исключены при rebase).

Доказательства (локально)

  • Тесты: 3968 passed (включая 2 RED-коммита в истории — enforce budget, terminal band).
  • Size: PASS (все гейты, включая animate+compositor 17500 и velocity-budget пины).
  • Typecheck: PASS. Audit: clean.

Контекст плана

Узел COMP-01 трека plans/lab-motion-production (agents-config). Разблокирует COMP-02 (#228) и COMP-03 (#235).

Rollback

Revert-PR squash-коммита; контракт опциональный (maxValueError — opt-in), потребители без опции не затронуты.

Claude Code and others added 12 commits August 18, 2026 20:08
Claude Code
feat(compositor): [#223] maxValueError bound in result units for surf…
54a82d7 
…ace lowering
Claude Code
test(compositor): RED enforce output-space error budget [#223]
a3b4b16
Claude Code
feat(compositor): integrate output-space error budget [#223]
d7898d9
Claude Code
docs(compositor): document output-space error contract [#223]
7dde0d3
Claude Code
test(compositor): extend pole-space error oracle [#223]
25d3b58
Claude Code
style(compositor): normalize error-bound export EOF [#223]
accf752
Claude Code
perf(compositor): keep value budget off controller bundles [#223]
ea302e6
Claude Code
perf(compositor): isolate effective tolerance law [#223]
8ada6e8
Claude Code
test(compositor): RED cover terminal tolerance band [#223]
74c8b6f
Claude Code
fix(compositor): guarantee full output-space tolerance band [#223]
895d468
Claude Code @sisyphus-dev-ai
perf(compositor): recover bundle size headroom [#223]
3660e07 
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Claude Code
test(compositor): завершить миграцию тестов на единый горизонт артефа…
0c5ebb7 
…кта [#223]

Все тестовые обращения к settleTimeUpperBound как к горизонту compositor-
исполнения переведены на durationMs артефакта
(compileSpringExecutionArtifactTupleUnchecked(...)[2]). Вектор
compiled-v0-spring conformance-корпуса перегенерирован тем же генератором:
кривая, durationMs трека и wireHex отражают unified effective-tolerance
горизонт (pre-1.0 поведенческая коррекция по контракту #223).
settleTimeUpperBound остаётся в тестах только как контракт spring.ts
(дифференциалы, законы оседания), не как горизонт артефакта.
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 45 minutes

Limit details: You’ve used all 1 included review currently available under your plan. You completed 105 included PR reviews in the past 7 days; at that activity level, included reviews refill at 1 review per hour.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2944f401-e3e8-41d0-8f48-a435b0b46566

📥 Commits

Reviewing files that changed from the base of the PR and between 9749fbf and 0c5ebb7.

📒 Files selected for processing (26)
  • CHANGELOG.md
  • conformance/motion-program-v1.json
  • docs/errors.md
  • src/compositor/cache.ts
  • src/compositor/core.ts
  • src/compositor/curve.ts
  • src/compositor/error-bound.ts
  • src/compositor/execution.ts
  • src/compositor/segmenter.ts
  • src/errors.ts
  • test/animate-group-clock-coherence.test.ts
  • test/animate-lifecycle-atomicity.test.ts
  • test/animate-scale-residual.test.ts
  • test/animate-seek-contract.test.ts
  • test/animate-surface-batch.test.ts
  • test/animate-waapi-lifecycle.test.ts
  • test/animate-waapi-long-delay.test.ts
  • test/compositor-compile.test.ts
  • test/compositor-error-bound.test.ts
  • test/compositor-handoff.test.ts
  • test/compositor-max-value-error.test.ts
  • test/compositor-retarget.test.ts
  • test/compositor-serialized-execution.test.ts
  • test/compositor-stagger.test.ts
  • test/compositor-velocity-budget.test.ts
  • test/compositor-webkit-execution.test.ts

Comment @coderabbitai help to get the list of available commands.

@lemone112
lemone112 merged commit 5003f1c into main Aug 18, 2026
9 of 13 checks passed
@lemone112
lemone112 deleted the feat/compositor-error-bound-223 branch August 18, 2026 18:40
This was referenced Aug 18, 2026
Closed
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lemone112